fix: Go generics cannot find common package object type definition #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use ast.SelectorExpr instead if ast.Ident to embed types - tests reworked fixes swaggo#1237
Codecov Report
@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
+ Coverage 94.95% 94.97% +0.01%
==========================================
Files 14 14
Lines 2717 2726 +9
==========================================
+ Hits 2580 2589 +9
Misses 78 78
Partials 59 59
Help us with your feedback. Take ten seconds to tell us how you rate us. |
- Generate full type name, if only one generic field exists - Generate refs to generic properties - Tests extended to test override behavior refs swaggo#1237 fixes swaggo#1253
- new tests added
|
@FabianMartin Thanks for your contribution. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Describe the PR
PR fixes the issues described in #1237 and #1253
Additionally, it reduces the generated doc size, cause it creates refs to types instead of embedding the fields
Relation issue
#1237
#1253
Additional context
All changes are backward compatible and have been tested with Go 1.15, 1.16, 1.17, 1.18 and 1.19.