New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functio scoped struct parse, tests #1283
add functio scoped struct parse, tests #1283
Conversation
@ubogdan Hi, can you review the changes when you are available? |
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
==========================================
+ Coverage 94.95% 95.04% +0.09%
==========================================
Files 14 14
Lines 2717 2787 +70
==========================================
+ Hits 2580 2649 +69
- Misses 78 79 +1
Partials 59 59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please improve the unit test for newly added code. |
I improved the unit tests according to changes |
Build failed |
Actually |
The error is obvious https://github.com/swaggo/swag/runs/7767202306?check_suite_focus=true , Try to run the tests against a go version lower than 1.18. |
Hey @ubogdan, I need your opinion here:
|
@mstrYoda I'm quite busy. I'm glad you figured out by yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mstrYoda Thanks for your contribution! |
Thank you for your effort |
Describe the PR
I added the functionality of parsing function scoped structs.
With this development we will be able to define our request response types in the same function scope as our handlers:
Relation issue
#1274
Additional context
All tests passed in parser_tests.go. Changes look backward compatible.