Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nested generic fields not fully working, if generic type is from… #1305

merged 2 commits into from Aug 25, 2022


Copy link

Describe the PR
Fixes the bug described in #1304

  • full name generation changed and support for SelectorExpr added
  • prepend package only, if type name does not contain package

Relation issue

Additional context
All changes are backward compatible and have been tested with Go 1.15, 1.16, 1.17, 1.18 and 1.19.

… another package

- change full name generation and support SelectorExpr
- prepend package only, if no name does not contain package

fixes swaggo#1304
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1305 (2b1c7de) into master (732c087) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1305      +/-   ##
+ Coverage   95.05%   95.47%   +0.41%     
  Files          14       14              
  Lines        2791     2804      +13     
+ Hits         2653     2677      +24     
+ Misses         79       72       -7     
+ Partials       59       55       -4     
Impacted Files Coverage Δ
generics.go 100.00% <100.00%> (+5.38%) ⬆️
operation.go 96.23% <0.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@sdghchj sdghchj merged commit 9d34a76 into swaggo:master Aug 25, 2022
12 checks passed
Copy link

sdghchj commented Aug 25, 2022

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants