Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generic Fields does not handle Arrays #1311

merged 2 commits into from Aug 28, 2022


Copy link

@FabianMartin FabianMartin commented Aug 27, 2022

Describe the PR
Fixes Bug described in #1306

  • Support for *ast.IndexExpr added to Parser.parseTypeExpr
  • tests extended to cover use cases

Relation issue

Additional context
All changes are backward compatible and have been tested with Go 1.15, 1.16, 1.17, 1.18 and 1.19.

- Support for *ast.IndexExpr added
- tests extended to cover use cases

fixes swaggo#1306
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #1311 (3d8255d) into master (007219f) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1311      +/-   ##
+ Coverage   95.47%   95.61%   +0.14%     
  Files          14       14              
  Lines        2805     2851      +46     
+ Hits         2678     2726      +48     
+ Misses         72       70       -2     
  Partials       55       55              
Impacted Files Coverage Δ
generics.go 100.00% <100.00%> (ø)
generics_other.go 100.00% <100.00%> (+33.33%) ⬆️
packages.go 90.70% <100.00%> (ø)
parser.go 93.88% <100.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@ubogdan ubogdan merged commit cf1c4a7 into swaggo:master Aug 28, 2022
12 checks passed
Copy link

ubogdan commented Aug 28, 2022

@FabianMartin Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants