/ swag Public
Fix formatting crosstalk #1317
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Describe the PR
Fixes formatting crosstalk (#1314) by modelling and applying formatting changes as byte-range edits rather than find/replace operations, which could accidentally clobber identical (correctly-formatted) comment lines.
Of course, everyone's experience will vary, but in the codebase I'm working in with – 4,132 attribute comments across 450 comment groups – this fix changes 8 comment lines. Those changes are pretty obvious and desirable, but I also don't anticipate that this will generate huge waves of changes in existing codebases.