Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1346 about generics #1348

Merged
merged 2 commits into from Oct 15, 2022
Merged

fix issue #1346 about generics #1348

merged 2 commits into from Oct 15, 2022

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Oct 15, 2022

Describe the PR
I don't know how to discribe this issue, but just fix it.

Relation issue
#1346

Signed-off-by: sdghchj <chengjin@cmiot.chinamobile.com>
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 95.64% // Head: 95.65% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (56c074e) compared to base (f8d59d6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1348   +/-   ##
=======================================
  Coverage   95.64%   95.65%           
=======================================
  Files          14       14           
  Lines        2871     2875    +4     
=======================================
+ Hits         2746     2750    +4     
  Misses         70       70           
  Partials       55       55           
Impacted Files Coverage Δ
generics.go 100.00% <100.00%> (ø)
generics_other.go 100.00% <100.00%> (ø)
packages.go 90.94% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 04c699c into master Oct 15, 2022
10 checks passed
@ubogdan ubogdan deleted the fix-generic branch Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants