Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generics issue #1345 #1349

Merged
merged 8 commits into from Oct 16, 2022
Merged

Fix generics issue #1345 #1349

merged 8 commits into from Oct 16, 2022

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Oct 15, 2022

Describe the PR
fix generic bug: a struct field with complex generic type.

for example:

type MyFieldStruct[T1 any, T2 any] struct {
        Data1   T1
        Data2   T2
}

type Nested[T any] struct{
        Value T
}

type MyStruct[T any] struct{
        Field1 *T
        Field2 []T
        Field3 MyFieldStruct[T, string]
        field4  Nested[Nested[string]]
}

Relation issue
#1345

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 95.65% // Head: 95.68% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (c264b4b) compared to base (04c699c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   95.65%   95.68%   +0.02%     
==========================================
  Files          14       14              
  Lines        2875     2894      +19     
==========================================
+ Hits         2750     2769      +19     
  Misses         70       70              
  Partials       55       55              
Impacted Files Coverage Δ
generics.go 100.00% <100.00%> (ø)
generics_other.go 100.00% <100.00%> (ø)
parser.go 93.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj merged commit 7f90377 into master Oct 16, 2022
10 checks passed
@sdghchj sdghchj deleted the fix-generics branch October 16, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants