New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generics with package alias #1360
Conversation
Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
Codecov ReportBase: 95.68% // Head: 95.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1360 +/- ##
==========================================
+ Coverage 95.68% 95.70% +0.02%
==========================================
Files 14 14
Lines 2894 2818 -76
==========================================
- Hits 2769 2697 -72
+ Misses 70 67 -3
+ Partials 55 54 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe the PR
fix generics bug:
View details in ./testdata/generics-package-alias
Now we determine mode type name conflict during the phase of collecting types, no longer determine during the parsing phase.
Relation issue
#1353