Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: record token.FileSet for every file #1393

merged 1 commit into from Nov 26, 2022


Copy link

@sdghchj sdghchj commented Nov 22, 2022

Describe the PR
sometimes, we want to know where the error is when parsing go files, so record token.FileSet for every file so that the position of parsing error can be acquired and output to log

Relation issue

Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 95.16% // Head: 95.10% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (d0089f2) compared to base (e5d507d).
Patch coverage: 78.94% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1393      +/-   ##
- Coverage   95.16%   95.10%   -0.06%     
  Files          15       15              
  Lines        3060     3067       +7     
+ Hits         2912     2917       +5     
- Misses         85       87       +2     
  Partials       63       63              
Impacted Files Coverage Δ
types.go 100.00% <ø> (ø)
packages.go 89.09% <75.00%> (-0.85%) ⬇️
parser.go 94.25% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sdghchj sdghchj requested a review from ubogdan November 24, 2022 12:13
@sdghchj sdghchj merged commit ba5df82 into master Nov 26, 2022
8 of 10 checks passed
@sdghchj sdghchj deleted the parse-error-postion branch November 26, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants