Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't error on empty comment line in matchExtension #1415

merged 1 commit into from Dec 12, 2022


Copy link

Describe the PR
parseExtension will break on empty comment lines //

Relation issue

Additional context
My previous test cases weren't covering empty comment lines and in that case fields[0] breaks.
Added fix and tests.

More than open for further suggestions/improvements if there are any

@igorkova igorkova changed the title fix: don't error on empty comment line fix: don't error on empty comment line in matchExtension Dec 11, 2022
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 85.22% // Head: 85.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (17965fd) compared to base (7c20f30).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1415   +/-   ##
  Coverage   85.22%   85.23%           
  Files          19       19           
  Lines        3635     3636    +1     
+ Hits         3098     3099    +1     
  Misses        459      459           
  Partials       78       78           
Impacted Files Coverage Δ
parser.go 94.39% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor Author

@ubogdan Thanks for the merge #1219 earlier today.
Will need a bit more of your time. 👍

@igorkova igorkova force-pushed the fix-parseextension-empty-comment branch from db17bf9 to 17965fd Compare December 11, 2022 21:11
@ubogdan ubogdan merged commit 7867c24 into swaggo:master Dec 12, 2022
10 checks passed
Copy link

ubogdan commented Dec 12, 2022

@igorkova Thanks for your contribution.

@igorkova igorkova deleted the fix-parseextension-empty-comment branch December 12, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants