Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse self-nested generic struct #1420

Merged
merged 2 commits into from Dec 12, 2022
Merged

parse self-nested generic struct #1420

merged 2 commits into from Dec 12, 2022

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Dec 12, 2022

Describe the PR
This PR aims to parse self-nested generic struct

Relation issue
#1408

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 85.22% // Head: 85.16% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (80f69d1) compared to base (7c20f30).
Patch coverage: 100.00% of modified lines in pull request are covered.

Current head 80f69d1 differs from pull request most recent head 9a343de. Consider uploading reports for the commit 9a343de to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
- Coverage   85.22%   85.16%   -0.07%     
==========================================
  Files          19       19              
  Lines        3635     3613      -22     
==========================================
- Hits         3098     3077      -21     
+ Misses        459      458       -1     
  Partials       78       78              
Impacted Files Coverage Δ
generics.go 100.00% <100.00%> (ø)
operation.go 96.10% <100.00%> (-0.17%) ⬇️
parser.go 94.55% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan ubogdan merged commit dfce6c8 into master Dec 12, 2022
8 checks passed
@ubogdan ubogdan deleted the nest-generic-struct branch December 12, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants