Skip to content
May 12, 2016
@swalberg
Add --allow-privileged=true to kubelet
1 commit with 1 addition and 1 deletion
May 12, 2016
@swalberg
  • @swalberg 549c2ea
    Add --allow-privileged=true to kubelet
May 12, 2016
May 12, 2016
May 12, 2016
May 12, 2016
@swalberg
  • @swalberg cf12c55
    Bump for release; update CHANGELOG
May 12, 2016
May 12, 2016
@swalberg
May 12, 2016
@swalberg
  • @rhass 9615920
    Add clone/bootstrap options. (#256)
May 12, 2016
@swalberg
Add clone/bootstrap options.
2 commits with 47 additions and 4 deletions
May 12, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

Looks great! Thanks, I'll merge this and cut a release.

May 11, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

Oh sorry I missed that you made updates. I'll review in the morning!

May 6, 2016
@swalberg

Aha, got it, thanks.

May 6, 2016
@swalberg

So just for clarity, you'd be passing it a UNC path? Or a local path with the installer being part of the template?

May 6, 2016
@swalberg

Hi, yes, I'm sure it could be added. At some point in the code we just hand over control to knife-windows. Are you downloading it to subsequently r…

May 4, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

That makes sense. All 3 branches of this if statement now have some kind of sleep (ipv4_address calls it at the top), do you think we could pull it…

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

I made a bunch of comments but my VPN isn't working now so I can't try it out. Will have another look tomorrow; I left this too late today, sorry.

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

👍 thanks for documenting this!

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

The block for detect should be a boolean, I think you probably meant addr.origin != 'linklayer'?

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

I think this method may benefit from a more descriptive name, especially if you decide to go back to the host/port/protocol signature for wait_for_…

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

Did you consider passing vm to connect_host and ipv4_address rather than using an instance var? Also the ||= is a bit jarring because it shouldn't…

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

What's the difference between @vm.guest.net[config[:bootstrap_nic]].ipConfig.ipAddress and @vm.guest.net[config[:bootstrap_nic]].ipAddress?

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

I think that removing the host argument from this method signature and having the method call connect_host itself might be giving this method too m…

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

Yes I agree.

May 3, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

Yes I think this line may be unnecessary.

Apr 30, 2016
swalberg commented on pull request chef-partners/knife-vsphere#256
@swalberg

Ryan, thanks for this fix. I know the v4 thing has bit people before and this'll be a welcome addition. I'm gone most of the weekend so won't be ab…

Apr 29, 2016
swalberg commented on pull request ajacksified/hubot-plusplus#65
@swalberg

Thanks!

Apr 27, 2016
@swalberg
Something went wrong with that request. Please try again.