Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): improve the evaluated blocks #1

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@manekinekko
Copy link
Contributor

commented Oct 8, 2019

This PR adds a persisted highlighting to the evaluated block.

@swallez
swallez approved these changes Oct 8, 2019
Copy link
Owner

left a comment

LGTM.

We could go further by removing decorations from a block as soon as we start editing it, but as it is it's a very useful addition that will help on stage where we mostly explain and evaluate code blocks without changing them much. Thanks!

@swallez swallez merged commit 9808571 into swallez:master Oct 8, 2019
swallez added a commit that referenced this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.