Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release a new gem version #160

Closed
brendon opened this issue Apr 30, 2015 · 5 comments
Closed

Release a new gem version #160

brendon opened this issue Apr 30, 2015 · 5 comments
Assignees
@brendon
Labels
question

Comments

@brendon
Copy link
Owner

brendon commented Apr 30, 2015

Hi Swanand, I've just bumped into the STI problem introduced in the last gem version. I think we should release a new gem version given the bug is pretty insidious (took me a while to figure out what was going wrong).

Sound good? :)
@swanandp
Copy link
Collaborator

Sure 👍

@swanandp
Copy link
Collaborator

Do you have a test case we can add to the suite ?

@brendon
Copy link
Owner Author

brendon commented Apr 30, 2015

I think the bug fix already has updated test cases to catch the regression that was introduced, so we just need to release the gem version unless you think it needs more coverage. It looks good to me though, and I've tried the master branch out in my app and it fixed the problem. :)

@swanandp
Copy link
Collaborator

swanandp commented May 1, 2015

Great, then. :shipit:

@swanandp swanandp assigned brendon and unassigned swanandp May 1, 2015
@brendon
Copy link
Owner Author

brendon commented May 1, 2015

Thanks Swanand, just released 0.7.0.

@brendon brendon closed this as completed May 1, 2015
@fabn fabn added the question label Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendon brendon

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brendon @swanandp @fabn