New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor column definer module #258

Merged
merged 10 commits into from Feb 27, 2017

Conversation

Projects
None yet
3 participants
@ledestin
Contributor

ledestin commented Feb 24, 2017

Tidy up ColumnMethodDefiner - extract some methods and other changes.

@swanandp

This comment has been minimized.

Show comment
Hide comment
@swanandp

swanandp Feb 27, 2017

Owner

I am generally skeptical about merging pure refactoring PRs, unless they serve a specific purpose. But this refactoring is looking good, and makes the code a lot more readable.

@brendon Unless you have any objections, we can merge this.

Owner

swanandp commented Feb 27, 2017

I am generally skeptical about merging pure refactoring PRs, unless they serve a specific purpose. But this refactoring is looking good, and makes the code a lot more readable.

@brendon Unless you have any objections, we can merge this.

@brendon

This comment has been minimized.

Show comment
Hide comment
@brendon

brendon Feb 27, 2017

Collaborator

Thanks @swanandp, @ledestin does some work for me as a contractor and is using this gem in his blog about refactoring. I think this is just continuing on from his work last year around splitting out the acts_as_list mega-method into more logical blocks. I'm happy to merge it too. :)

Collaborator

brendon commented Feb 27, 2017

Thanks @swanandp, @ledestin does some work for me as a contractor and is using this gem in his blog about refactoring. I think this is just continuing on from his work last year around splitting out the acts_as_list mega-method into more logical blocks. I'm happy to merge it too. :)

@brendon brendon merged commit 024ffe0 into swanandp:master Feb 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

IlkhamGaysin pushed a commit to IlkhamGaysin/acts_as_list that referenced this pull request Mar 1, 2017

IlkhamGaysin
Merge branch 'master' into no-update-for-collection-classes
* master:
  Refactor column definer module (#258)
  Fix deprecation introduced in ActiveRecord 5.1.
  Add rails 5.1.0.beta1 and ruby 2.4 to test matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment