Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails4 compatibility #80

Merged
merged 6 commits into from Jul 28, 2013

Conversation

Projects
None yet
9 participants
@philippfranke
Copy link
Collaborator

philippfranke commented Apr 10, 2013

Acts as list doesn鈥檛 support rails4 yet so I changed a bit:

Rails 4 support: 馃挴

@conzett

This comment has been minimized.

Copy link
Contributor

conzett commented Apr 11, 2013

+1 from me 1.87 is almost EOL. Probably necessitates a bump in the major version number.

@javierjulio

This comment has been minimized.

Copy link

javierjulio commented Apr 11, 2013

+1 thanks @philippfranke! Be great to get Rails 4 support in.

@swanandp

This comment has been minimized.

Copy link
Owner

swanandp commented Apr 12, 2013

@philippfranke @conzett Let us merge the scope array fix and push a version out, we can then merge this and increment the major version number.

@eka

This comment has been minimized.

Copy link

eka commented Jun 28, 2013

+1

@javierjulio

This comment has been minimized.

Copy link

javierjulio commented Jun 28, 2013

+1 - we are using acts_as_list and would be great if we could get this in so we can upgrade to Rails 4.

@conzett

This comment has been minimized.

Copy link
Contributor

conzett commented Jun 28, 2013

@philippfranke @swanandp Working on getting array scope stuff fixed up for 1.8.7 right now, so you can do that last minor release, sorry for delay. Edit: scope array fix is passing now.

@tibra

This comment has been minimized.

Copy link

tibra commented Jun 28, 2013

+1 @philippfranke 鈥 thank you!

@philippfranke

This comment has been minimized.

Copy link
Collaborator Author

philippfranke commented Jul 17, 2013

After #81 was merged, you can finally merge this pull( #80 ) as well.

/cc @swanandp

@javierjulio

This comment has been minimized.

Copy link

javierjulio commented Jul 18, 2013

Thanks @philippfranke!

@chibicode

This comment has been minimized.

Copy link

chibicode commented Jul 22, 2013

馃憤

1 similar comment
@rimenes

This comment has been minimized.

Copy link

rimenes commented Jul 26, 2013

+1

@kolodovskyy

This comment has been minimized.

Copy link

kolodovskyy commented Jul 26, 2013

Thanks! +1

@philippfranke

This comment has been minimized.

Copy link
Collaborator Author

philippfranke commented Jul 27, 2013

Finally, you can merge it. /cc @swanandp

@javierjulio

This comment has been minimized.

Copy link

javierjulio commented Jul 28, 2013

馃憤

swanandp added a commit that referenced this pull request Jul 28, 2013

@swanandp swanandp merged commit d8d4155 into swanandp:master Jul 28, 2013

1 check passed

default The Travis CI build passed
Details
@swanandp

This comment has been minimized.

Copy link
Owner

swanandp commented Jul 28, 2013

Thanks @philippfranke!

@philippfranke philippfranke deleted the philippfranke:rails4_compatibility branch Jul 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.