Jesse Wilson swankjesse

swankjesse commented on pull request square/okio#135
@swankjesse

Works for me.

swankjesse commented on issue square/javapoet#197
@swankjesse

We have a model problem. In our current model, a type’s name is a function of where it’s attached. A type nested within another type doesn’t contro…

swankjesse commented on pull request square/okio#135
@swankjesse

should this have helper functions ? ByteRate byteRate = new ByteRate(); byteRate.kBps(28); byteRate.mBps(28); The bytes/bits nonsense burns us a b…

swankjesse commented on pull request square/okio#135
@swankjesse

try/finally ?

swankjesse commented on pull request square/okio#135
@swankjesse

I think this is a for loop

swankjesse commented on pull request square/okio#135
@swankjesse

This isn't right. You can defeat the rate by manipulating the frequency of calls to write(). You need to keep a long written field member that star…

swankjesse commented on pull request square/okio#135
@swankjesse

nice null checks!

swankjesse commented on pull request square/okio#135
@swankjesse

apply?

swankjesse commented on pull request square/okio#135
@swankjesse

very interesting name. I don't hate it!

swankjesse commented on pull request square/okio#135
@swankjesse

copyright

swankjesse commented on issue square/okhttp#1539
@swankjesse
CertificatePinner uses sha1 hashes
swankjesse commented on issue square/okhttp#1538
@swankjesse

The format we use is the same as Chrome's. If they ever support multiple formats, we might also.

@swankjesse
Support sha256 digest on CertificatePinner
swankjesse commented on issue square/okhttp#1538
@swankjesse

I'd prefer to keep one hash mechanism only. If you'd like another, consider following this example: https://github.com/square/okhttp/blob/master/sa…

@swankjesse
GzipRequestInterceptor crash
swankjesse commented on issue square/okhttp#1537
@swankjesse

Install this as an application interceptor, not as a network interceptor. client.interceptors().add(new GzipRequestInterceptor()); The interceptor…

swankjesse commented on issue square/retrofit#794
@swankjesse

My preference is to always explicitly specify UTF-8. For consumers, explicitly specifying it permits some optimizations: you can avoid a potentiall…

swankjesse commented on issue square/okio#134
@swankjesse

That's so awesome. Thank you!

swankjesse commented on issue square/okio#134
@swankjesse

Well, the device mix rules out lousy devices as the cause. Must be in Okio. This is really strange. At some point there's a disconnect between the …

swankjesse commented on issue square/okio#134
@swankjesse

Any particular patterns on the devices hosting the 55 crashes? I fear there are devices with broken synchronized support!

@swankjesse
Hook up ProviderInstaller
swankjesse commented on issue square/okio#134
@swankjesse

Yikes, that's very bad. Can you reproduce this?

swankjesse commented on issue square/okhttp#1535
@swankjesse

The exception that's crashing your app is not the one pasted. Step through with a debugger if you'd like to confirm that!

swankjesse commented on issue square/okhttp#1535
@swankjesse

The exception is just a warning; that just means you didn't close the response body.

@swankjesse
java.lang.Throwable: Explicit termination method 'end' not called
swankjesse commented on issue square/okhttp#1534
@swankjesse

Off topic: does that message show up in your user interface? Probably a lousy idea because it lends itself to injection attacks: ../html/dynamicSpo…

@swankjesse
Not following correct URL in redirect because of the encoding
@swankjesse
  • @swankjesse 9338fa1
    Make OkHttpClient and Call final.
@swankjesse
Slow establishing connection to one site but not others