TODOs fixed in core.logic, via LOGIC-100 and LOGIC-101 patches.

swannodette · Jan 7, 2013 · 2b05829 · 2b05829
1 parent 43f065d
commit 2b05829
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/clojure-tapl/tapl/src/tapl/stlce.clj b/clojure-tapl/tapl/src/tapl/stlce.clj
@@ -87,8 +87,6 @@
        (conso [y tyy] gammap gamma)
        (conde
          [(== y x) (== tyb `(~'type ~tyy))]
-         ;; TODO(namin): we get spurious results if we use nom/hash instead of !=.
-         ;;  This indicates a potential problem with nom/hash and variable noms.
          [(!= y x) (lookupo gammap x tyb)]))]))
 
 (defn typingo [gamma t tyb]

diff --git a/clojure-tapl/tapl/test/tapl/test/stlce.clj b/clojure-tapl/tapl/test/tapl/test/stlce.clj
@@ -19,8 +19,7 @@
            (nom/fresh [x]
              (typingo () `(~'fn ~(nom/tie x [x x])) q)))
         '(((error (not-arrow-type _0)) :- (!= (_0 [:=> _1 _2])))
-          ;; TODO(namin): The != below is spurious b/c of occurs-check. Is it worth fixing?
-          ((error (incompatible-types _0 [:=> _0 _1])) :- (!= (_0 [:=> _0 _1])))))))
+          (error (incompatible-types _0 [:=> _0 _1]))))))
 
 (deftest test-typingo-unbound-var
   (is (= (run* [q]