Skip to content
Browse files

TODOs fixed in core.logic, via LOGIC-100 and LOGIC-101 patches.

  • Loading branch information...
1 parent 43f065d commit 2b058294d90c9950c8e347d91fa8623a70c96647 @namin namin committed
Showing with 1 addition and 4 deletions.
  1. +0 −2 clojure-tapl/tapl/src/tapl/stlce.clj
  2. +1 −2 clojure-tapl/tapl/test/tapl/test/stlce.clj
View
2 clojure-tapl/tapl/src/tapl/stlce.clj
@@ -87,8 +87,6 @@
(conso [y tyy] gammap gamma)
(conde
[(== y x) (== tyb `(~'type ~tyy))]
- ;; TODO(namin): we get spurious results if we use nom/hash instead of !=.
- ;; This indicates a potential problem with nom/hash and variable noms.
[(!= y x) (lookupo gammap x tyb)]))]))
(defn typingo [gamma t tyb]
View
3 clojure-tapl/tapl/test/tapl/test/stlce.clj
@@ -19,8 +19,7 @@
(nom/fresh [x]
(typingo () `(~'fn ~(nom/tie x [x x])) q)))
'(((error (not-arrow-type _0)) :- (!= (_0 [:=> _1 _2])))
- ;; TODO(namin): The != below is spurious b/c of occurs-check. Is it worth fixing?
- ((error (incompatible-types _0 [:=> _0 _1])) :- (!= (_0 [:=> _0 _1])))))))
+ (error (incompatible-types _0 [:=> _0 _1]))))))
(deftest test-typingo-unbound-var
(is (= (run* [q]

0 comments on commit 2b05829

Please sign in to comment.
Something went wrong with that request. Please try again.