Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Optimization & Image Lazy Loading #204

Merged
merged 7 commits into from
Feb 21, 2021

Conversation

QuatZo
Copy link
Collaborator

@QuatZo QuatZo commented Feb 21, 2021

  • Added Lazy loading for all images
  • Cleaned up filter url (i.e. name=&natural_stars=1,6&fusion_food=&skills__passive=&skills__aoe=&skills__cooltime=0,13&skills__hits=0,7&page=1&sort= changed to page=1)
  • Optimized Bestiary/Monsters Database calls

It also partially resolves given Feedback

Whenever you click on bestiary, swarfarm load every monster before you can modify filter, making swarfam super slow especicaly on my phone, maybe, for the first loading, don't load monster and wait for the user to press apply to filter.

Loading time [seconds] SWARFARM (before) LOCAL (after)
Bestiary 7 1
Monsters 6.5 3.5
Runes 10 8
Artifacts 1.5 <0.5

bestiary/filters.py Show resolved Hide resolved
herders/filters.py Show resolved Hide resolved
@PeteAndersen PeteAndersen merged commit 8dee4ff into swarfarm:master Feb 21, 2021
@QuatZo QuatZo deleted the optimization branch February 21, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants