rename 'portable' to 'pickable' #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When we merge this we should also remember to regenerate affected wiki cheat sheets. |
byorgey
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
I see that we are doing #845 now too. 😄 I'm fine with that. Though I did notice a few things that need cleaning up. I didn't look at absolutely every single change so we should try searching for additional instances of the things I pointed out.
data/scenarios/Testing/1575-structure-recognizer/1575-ensure-disjoint.yaml
Outdated
Show resolved
Hide resolved
data/scenarios/Testing/1575-structure-recognizer/1575-ensure-disjoint.yaml
Outdated
Show resolved
Hide resolved
data/scenarios/Testing/1575-structure-recognizer/1575-ensure-single-recognition.yaml
Outdated
Show resolved
Hide resolved
data/scenarios/Testing/1575-structure-recognizer/1575-ensure-single-recognition.yaml
Outdated
Show resolved
Hide resolved
mergify bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
Towards #845 This is to avoid the undesirable transformation by `yq` of whitespace-preserving string fields into quoted one-line strings, described in #1706 (comment). Command: find data/scenarios -type f -name '*.yaml' -print0 | xargs -0 --max-args 1 sed -i -e 's/[[:blank:]]\+$//'
mergify bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
YAML syntax in this file was actually fixed in #1672, which is not yet merged. Cherry-pick that fix as well as enhancements to the scenario. Towards #845. Aside from fixing the syntax for #1706 (comment), this provides a good "before" example to showcase the fix in #1672. scripts/run-tests.sh --test-arguments '--pattern "1034-custom-attributes"' and scripts/play.sh -i data/scenarios/Testing/1034-custom-attributes.yaml --autoplay --speed 1 
kostmo
changed the base branch from
main
to
refactor/normalize-entities-recipes
kostmo
force-pushed
the
refactor/portable-to-pickable
branch
2 times, most recently
from
e0b4f54
to
4f8516f
Compare
byorgey
approved these changes
Jan 5, 2024
kostmo
force-pushed
the
refactor/portable-to-pickable
branch
from
4f8516f
to
a842cda
Compare
kostmo
force-pushed
the
refactor/normalize-entities-recipes
branch
from
5b1c3b1
to
7f2be5b
Compare
kostmo
force-pushed
the
refactor/portable-to-pickable
branch
from
a842cda
to
273cab1
Compare
kostmo
changed the base branch from
refactor/normalize-entities-recipes
to
main
kostmo
force-pushed
the
refactor/portable-to-pickable
branch
from
273cab1
to
c0f604a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1695.
Updating occurrences was pretty easy:
and