Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SignalHandlerProcessor #186

Merged
merged 3 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@lyrixx
Copy link
Contributor

commented Apr 29, 2019

Before the patch, the signal handler where unregister in the shouldStop method. so basically ... it does not work

@odolbeau

This comment has been minimized.

Copy link
Member

commented May 5, 2019

Nice catch, thanks!
I think you can simply remove those lines, removing the custom signal handler doesn't makes sense IMO.

@lyrixx

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

@odolbeau Done 👌

@@ -67,7 +63,7 @@ public function process(Message $message, array $options)
{
$return = $this->processor->process($message, $options);
if (extension_loaded('pcntl') && $this->shouldStop($options)) {

This comment has been minimized.

Copy link
@lyrixx

lyrixx May 9, 2019

Author Contributor

I don't understand this code. IMHO this is wrong. We should always return $return, isn't ?

This comment has been minimized.

Copy link
@odolbeau

odolbeau May 13, 2019

Member

Right!

@odolbeau

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Thanks for those nice improvements!

@odolbeau odolbeau merged commit 4b945ad into swarrot:master May 13, 2019

1 of 2 checks passed

Scrutinizer Errored
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lyrixx lyrixx deleted the lyrixx:signal branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.