Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

titlebar hiding not respected after closing last sibling #2987

Closed
julientechdev opened this issue Oct 26, 2018 · 2 comments
Closed

titlebar hiding not respected after closing last sibling #2987

julientechdev opened this issue Oct 26, 2018 · 2 comments

Comments

@julientechdev
Copy link

julientechdev commented Oct 26, 2018 •
edited

This one is a bug and a regression from i3 behaviour.

Required config:

new_window pixel 2
new_float pixel 2
workspace_layout default
hide_edge_borders smart (this one is probably not be related)

Current behaviour:

  • Open a window on an empty workspace (titlebar is hidden)
  • Open a second window on the same workspace (titlebars are visible)
  • Put them into stack or tabbed (titlebars are visible)
  • Close one window, leaving only one -> titlebar is visible but should be hidden

When there is only one window in a workspace, it should have only one container (previous parents should be removed) and title bar should be hidden if configured so.
@RedSoxFan
Copy link
Member

Duplicate of #2912

@RedSoxFan RedSoxFan marked this as a duplicate of #2912 Oct 26, 2018
@progandy progandy mentioned this issue Oct 30, 2018
Merged
@julientechdev
Copy link
Author

julientechdev commented Jan 14, 2019 •
edited

I still have this issue even though #3031 was merged.
I am running master and update several times a week, and the issue was never fixed.

Can someone reopen or shall I create another ticket ?

@julientechdev julientechdev mentioned this issue Feb 12, 2019
Closed
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
@thejan2009
introduce hide_edge_borders lone_tab
bc12841 
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
@thejan2009
introduce hide_edge_borders lone_tab
1f200d4 
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
@thejan2009 thejan2009 mentioned this issue Feb 24, 2019
Merged
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
@thejan2009
introduce hide_edge_borders lone_tab
6116bc8 
Behaves same as _both_ in i3wm with regards to tabbed/stacked containers. If
there is only one tabbed/stacked container child, title bar is hidden.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
@thejan2009
add --i3 flag to hide_edge_borders
7f2936f 
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
thejan2009 added a commit to thejan2009/sway that referenced this issue Feb 24, 2019
@thejan2009
add --i3 flag to hide_edge_borders
b7a2a1b 
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: swaywm#3031, swaywm#3002, swaywm#2912, swaywm#2987.
RedSoxFan pushed a commit that referenced this issue Feb 24, 2019
@thejan2009 @RedSoxFan
add --i3 flag to hide_edge_borders
2510e3d 
Enables i3-compatible behavior regarding hiding the title bar on tabbed and
stacked containers with one child.

Related issues and merge requests: #3031, #3002, #2912, #2987.
@alecmev alecmev mentioned this issue May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julientechdev @RedSoxFan