New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airblader fork features #307

Closed
SirCmpwn opened this Issue Dec 13, 2015 · 17 comments

Comments

Projects
None yet
6 participants
@SirCmpwn
Member

SirCmpwn commented Dec 13, 2015

This issue tracks our progress implementing the features of @Airblader's i3 fork: https://github.com/Airblader/i3

Commands:

  • gaps
  • workspace gaps [inner|outer]
  • smart_gaps
  • smart_borders
  • bar { border }
  • bar { height }
  • rgba colors
@mikkeloscar

This comment has been minimized.

Show comment
Hide comment
@mikkeloscar

mikkeloscar Dec 15, 2015

Collaborator

Do you know what a block is in the context of a bar? I'm trying to figure out how bar { border } should be implemented in the config file and the airblader/i3 docs mention individual blocks, but I'm not sure what those blocks are?

Any idea what bar { border } should look like in the config?

Collaborator

mikkeloscar commented Dec 15, 2015

Do you know what a block is in the context of a bar? I'm trying to figure out how bar { border } should be implemented in the config file and the airblader/i3 docs mention individual blocks, but I'm not sure what those blocks are?

Any idea what bar { border } should look like in the config?

@SirCmpwn

This comment has been minimized.

Show comment
Hide comment
@SirCmpwn

SirCmpwn Dec 15, 2015

Member

That's not a config file option, it's part of the JSON you can send via stdout from status_command to have formatted colors and such.

Member

SirCmpwn commented Dec 15, 2015

That's not a config file option, it's part of the JSON you can send via stdout from status_command to have formatted colors and such.

@Airblader

This comment has been minimized.

Show comment
Hide comment
@Airblader

Airblader Dec 17, 2015

In your swaybar screenshot from today it seems to me that the gaps are actually implemented incorrectly. The spacing between two windows is double the spacing on the screen edges. This was a bug in the old original gaps patch which I've fixed quite a while ago.

Airblader commented Dec 17, 2015

In your swaybar screenshot from today it seems to me that the gaps are actually implemented incorrectly. The spacing between two windows is double the spacing on the screen edges. This was a bug in the old original gaps patch which I've fixed quite a while ago.

@SirCmpwn

This comment has been minimized.

Show comment
Hide comment
@SirCmpwn

SirCmpwn Dec 17, 2015

Member

I have the gaps configured like so in that screenshot:

gaps outer 0
gaps inner 10

Incorrect?

Member

SirCmpwn commented Dec 17, 2015

I have the gaps configured like so in that screenshot:

gaps outer 0
gaps inner 10

Incorrect?

@Airblader

This comment has been minimized.

Show comment
Hide comment
@Airblader

Airblader Dec 17, 2015

Your settings are fine, but the gaps implementation is wrong. Using the same gaps settings in i3-gaps, see the following screenshot. The gap between the two windows is just as big as the gap between a window and the screen edge, as it should be. In sway this seems to be incorrect because the gap between two windows is double the size of the gap between window and screen edge.

This is (at least in i3) a problem because if you just inset a window, you will naturally run into this problem. What you need to do is divide the gaps by two for edges between two windows.

screenshot-2015-12-17_07-07-21

Airblader commented Dec 17, 2015

Your settings are fine, but the gaps implementation is wrong. Using the same gaps settings in i3-gaps, see the following screenshot. The gap between the two windows is just as big as the gap between a window and the screen edge, as it should be. In sway this seems to be incorrect because the gap between two windows is double the size of the gap between window and screen edge.

This is (at least in i3) a problem because if you just inset a window, you will naturally run into this problem. What you need to do is divide the gaps by two for edges between two windows.

screenshot-2015-12-17_07-07-21

@SirCmpwn

This comment has been minimized.

Show comment
Hide comment
@SirCmpwn

SirCmpwn Dec 17, 2015

Member

I see. The gaps right now are just implemented as margins. I'll see about fixing this, thanks!

Member

SirCmpwn commented Dec 17, 2015

I see. The gaps right now are just implemented as margins. I'll see about fixing this, thanks!

@Airblader

This comment has been minimized.

Show comment
Hide comment
@Airblader

Airblader Dec 17, 2015

Sure, no problem. Does sway support fullscreening nested containers? You might want to check gap behavior there, too, as in i3-gaps I had to do some fixes for it.

Airblader commented Dec 17, 2015

Sure, no problem. Does sway support fullscreening nested containers? You might want to check gap behavior there, too, as in i3-gaps I had to do some fixes for it.

@SirCmpwn

This comment has been minimized.

Show comment
Hide comment
@SirCmpwn

SirCmpwn Dec 17, 2015

Member

As in fullscreening the actual container, instead of views? No, that's not supported, but would probably be fairly easy to do.

Member

SirCmpwn commented Dec 17, 2015

As in fullscreening the actual container, instead of views? No, that's not supported, but would probably be fairly easy to do.

@Airblader

This comment has been minimized.

Show comment
Hide comment
@Airblader

Airblader Dec 17, 2015

We don't really support this in i3 either, but it does work for the most part. It's not really a big deal. I honestly don't see why you'd want to fullscreen nested containers anyway. :)

Airblader commented Dec 17, 2015

We don't really support this in i3 either, but it does work for the most part. It's not really a big deal. I honestly don't see why you'd want to fullscreen nested containers anyway. :)

@SirCmpwn

This comment has been minimized.

Show comment
Hide comment
@SirCmpwn

SirCmpwn Dec 17, 2015

Member

I could see it being useful if you have a complicated layout going and you want to focus on only some part of it for a while. You're right that I don't consider it a high priority, though. Sway also doesn't support floating containers like i3 does.

Member

SirCmpwn commented Dec 17, 2015

I could see it being useful if you have a complicated layout going and you want to focus on only some part of it for a while. You're right that I don't consider it a high priority, though. Sway also doesn't support floating containers like i3 does.

@StephenBrown2

This comment has been minimized.

Show comment
Hide comment
@StephenBrown2

StephenBrown2 Dec 18, 2015

Contributor

I thought that was fixed with #96 ?

Contributor

StephenBrown2 commented Dec 18, 2015

I thought that was fixed with #96 ?

@Airblader

This comment has been minimized.

Show comment
Hide comment
@Airblader

Airblader Dec 18, 2015

Looks like it, yes, but the screenshot I saw from @SirCmpwn had the bug.

Airblader commented Dec 18, 2015

Looks like it, yes, but the screenshot I saw from @SirCmpwn had the bug.

@SirCmpwn SirCmpwn added the easy label Nov 25, 2016

@SirCmpwn SirCmpwn referenced this issue Apr 8, 2017

Closed

i3 feature support #2

77 of 81 tasks complete
@nixpulvis

This comment has been minimized.

Show comment
Hide comment
@nixpulvis

nixpulvis Dec 17, 2017

I'm a bit new to bar configuration, but is there a way to add margin/gaps around the bar easily too?

nixpulvis commented Dec 17, 2017

I'm a bit new to bar configuration, but is there a way to add margin/gaps around the bar easily too?

@SirCmpwn

This comment has been minimized.

Show comment
Hide comment
@SirCmpwn

SirCmpwn Dec 17, 2017

Member

Not presently, no.

Member

SirCmpwn commented Dec 17, 2017

Not presently, no.

@nixpulvis

This comment has been minimized.

Show comment
Hide comment
@nixpulvis

nixpulvis Dec 17, 2017

Oh well, might be worth adding a gaps set of options to the bar config. I know people have accomplished this kind of thing with polybar, but if my understanding is correct that depends on an X server.

nixpulvis commented Dec 17, 2017

Oh well, might be worth adding a gaps set of options to the bar config. I know people have accomplished this kind of thing with polybar, but if my understanding is correct that depends on an X server.

@emersion

This comment has been minimized.

Show comment
Hide comment
@emersion

emersion Oct 9, 2018

Member

We have implemented everything in master.

Member

emersion commented Oct 9, 2018

We have implemented everything in master.

@emersion emersion closed this Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment