Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very large inner gaps break layout #4294

Closed
pedrocr opened this issue Jun 28, 2019 · 1 comment
Closed

Very large inner gaps break layout #4294

pedrocr opened this issue Jun 28, 2019 · 1 comment

Comments

@pedrocr
Copy link
Contributor

pedrocr commented Jun 28, 2019

When using very large gaps the layout becomes broken. To reproduce do something like swaymsg gaps inner all set 200 and then open a bunch of terminals horizontally. At some point the layout becomes broken with incorrectly rendered windows. Something like this:

broken_gaps_layout

These are not just incorrectly sized windows, the rendering seems actually broken.
pedrocr added a commit to pedrocr/sway that referenced this issue Jun 30, 2019
@pedrocr
Limit gap sizing to sensible values
f9caba9 
Large inner gaps can lead to broken rendering with width/height going
negative. Limit the gaps so that they never make the windows smaller
than a minimum sensible size (the same used for the resize command).

Fixes swaywm#4294
@pedrocr pedrocr mentioned this issue Jun 30, 2019
Closed
@pedrocr
Copy link
Contributor Author

pedrocr commented Jun 30, 2019

For an even weirder manifestation of this bug run something like:

swaymsg gaps inner all set 10000

Now all your windows will disappear completely.

pedrocr added a commit to pedrocr/sway that referenced this issue Jul 1, 2019
@pedrocr
Limit gap sizing to sensible values
ca44661 
Large inner gaps can lead to broken rendering with width/height going
negative. Limit the gaps so that they never make the windows smaller
than a minimum sensible size (the same used for the resize command).

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 2, 2019
@pedrocr
Limit gap sizing to sensible values
4fd592a 
Large inner gaps can lead to broken rendering with width/height going
negative. Limit the gaps so that they never make the windows smaller
than a minimum sensible size (the same used for the resize command).

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 2, 2019
@pedrocr
Limit gap sizing to sensible values
3b738b7 
Large inner gaps can lead to broken rendering with width/height going
negative. Limit the gaps so that they never make the windows smaller
than a minimum sensible size (the same used for the resize command).

Fixes swaywm#4294
@pedrocr pedrocr changed the title Very large gaps break layout Very large inner gaps break layout Jul 2, 2019
@pedrocr pedrocr mentioned this issue Jul 2, 2019
Closed
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 2, 2019
@pedrocr
Limit gap sizing to sensible values
e85ebca 
Large inner gaps can lead to broken rendering with width/height going
negative. Limit the gaps so that they never make the windows smaller
than a minimum sensible size (the same used for the resize command).

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 4, 2019
@pedrocr
Limit inner gaps to sensible values
b589767 
Large inner gaps can lead to broken rendering with width/height going
negative. Limit the gaps so that they never make the windows smaller
than a minimum sensible size (the same used for the resize command).

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 6, 2019
@pedrocr
Sanity check gaps between tiled containers
c57909f 
When the gaps become too large for the space available gracefully
reduced them all the way to 0 if needed.

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 6, 2019
@pedrocr
Sanity check gaps between tiled containers
9f8b265 
When the gaps become too large for the space available gracefully
reduced them all the way to 0 if needed.

Fixes swaywm#4294
@pedrocr pedrocr mentioned this issue Jul 6, 2019
Merged
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 6, 2019
@pedrocr
Sanity check gaps between tiled containers
a5c72e4 
When the gaps become too large for the space available gracefully
reduced them all the way to 0 if needed.

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 14, 2019
@pedrocr
Sanity check gaps between tiled containers
5132a40 
When the gaps become too large for the space available gracefully
reduced them all the way to 0 if needed.

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 14, 2019
@pedrocr
Sanity check gaps between tiled containers
79fcc35 
When the gaps become too large for the space available gracefully
reduced them all the way to 0 if needed.

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 14, 2019
@pedrocr
Sanity check gaps between tiled containers
1a4ad5c 
When the gaps become too large for the space available gracefully
reduced them all the way to 0 if needed.

Fixes swaywm#4294
pedrocr added a commit to pedrocr/sway that referenced this issue Jul 15, 2019
@pedrocr
Sanity check gaps between tiled containers
6b90d46 
When the gaps become too large for the space available gracefully
reduced them all the way to 0 if needed.

Fixes swaywm#4294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework the gaps code so sizes are correct and to prevent broken layouts pedrocr/sway
1 participant
@pedrocr