Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Tabbed and stacked layout #566
This is now ready for review/merge.
There's one known bug in wlc, that causes views to become invisible when moved away from a tabbed/stacked layout in some cases. (Will be fixed separately, obviously).
This is just to let other people follow the progress and for me to have some sort of checklist for bugs I find.
Will update when ready for review.
added a commit
this pull request
Apr 1, 2016
I have some thoughts on the implementation. I'm concerned about the performance of walking up the tree to find a stacked/tabbed parents somewhere. I'm also not a fan of the approach to not drawing children's borders, and how stacked/tabbed is an explicit special case in many places. I would prefer an implementation that, perhaps, would instead allow containers to have borders and code it to stop rendering borders when recursively laying out going into a stacked/tabbed container.
We need some way to detect this, since tabbed/stacked is a special case, but it could possible be handled better by making a separate
I'm not sure I follow. Since we draw the borders in
I'm not sure what you mean. If you mean that the container could draw the tabbed/stacked titlebars then I don't see the benefit since the visible view has to render the border anyway.