Ignore modifiers on bindsym release, to match i3 behaviour #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is how i3 behaves. Can someone check? |
|
Looks like you're right: https://github.com/i3/i3/blob/next/src/bindings.c#L239 They check to see if the bindings are exact. With that being said: https://github.com/i3/i3/blob/next/src/bindings.c#L243 It appears they completely ignore modifiers when a button is being released. In the end, that means I can't push my PTT key if my shift button is held down, but if that's how i3 does it, then c'est la vie. I can make the appropriate changes to this PR. |
Closes swaywm#6456. The i3 window manager ignores modifiers when a button is being released. Mimic this behaviour in Sway.
k3d3
changed the title
|
Changes made. |
|
The i3 logic is a bit more complicated: it only ignores modifiers if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6456.
The i3 window manager ignores modifiers when a button is being released. Mimic this behaviour in Sway.
As this is my first commit to Sway, let me know if there's anything else you need!
Thanks