Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set color transform when calling wlr_scene_output_build_state() #8200

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Jun 8, 2024

We were only passing the color transform when calling wlr_scene_output_commit(). However when modesetting or pushing a new gamma LUT we render via wlr_scene_output_build_state(). Pass the color transform there as well.

cc @mstoeckl

We were only passing the color transform when calling
wlr_scene_output_commit(). However when modesetting or pushing a
new gamma LUT we render via wlr_scene_output_build_state(). Pass
the color transform there as well.
@GreyXor
Copy link

GreyXor commented Jun 8, 2024

Just tested and I confirm it fixes: #7681 (comment)

Copy link
Contributor

@mstoeckl mstoeckl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I had entirely overlooked wlr_scene_output_build_state when I made the original PR.

@Nefsen402
Copy link
Member

LGTM

@kennylevinsen kennylevinsen merged commit cc34210 into master Jun 10, 2024
3 checks passed
@kennylevinsen kennylevinsen deleted the missing-color-transform branch June 10, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants