-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ext-session-lock-v1 #219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next commit will need that version. Adjust the build to not trigger deprecation warnings.
This allows building swaylock with a local wayland-protocols.
emersion
force-pushed
the
lock-proto
branch
2 times, most recently
from
December 20, 2021 19:18
7f0159a
to
22acde7
Compare
emersion
changed the title
Add support for ext-lock-v1
Add support for ext-session-lock-v1
Dec 20, 2021
4 tasks
ifreund
reviewed
Dec 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me with the ext-session-lock-v1
implementation in river here riverwm/river#497 and the wl_surface_commit()
call mentioned below removed when using ext-session-lock-v1
.
Addressed the comments, thanks for the review! |
This is a new protocol to lock the session [1]. It should be more reliable than layer-shell + input-inhibitor. [1]: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/131
Closed
This was referenced Mar 9, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new protocol to lock the session 1. It should be more
reliable than layer-shell + input-inhibitor.
To build locally:
mkdir subprojects git clone "git@gitlab.freedesktop.org:ifreund/wayland-protocols.git" -b ext-lock-v1 subprojects/wayland-protocols meson configure build/ --force-fallback-for=wayland-protocols