Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rootston views #1568

Merged
merged 3 commits into from Feb 23, 2019

Conversation

Projects
None yet
2 participants
@emersion
Copy link
Member

emersion commented Feb 23, 2019

  • Refactor views
    • Use an interface
    • Use embedded structs
  • Refactor view children: use an interface

Follow-up refactoring:

  • Refactor input code
  • Refactor surface iterators

Updates #839

emersion added some commits Feb 23, 2019

@emersion emersion changed the title [WIP] Refactor rootston Refactor rootston views Feb 23, 2019

@emersion

This comment has been minimized.

Copy link
Member Author

emersion commented Feb 23, 2019

This PR is big enough as-is. I'll do the two remaining refactoring tasks in separate PRs.

This is now ready for review. This basically makes the rootston code more in line with the sway code. I've tried to split this refactoring into not-too-big commits to ease review.

@ddevault

This comment has been minimized.

Copy link
Member

ddevault commented Feb 23, 2019

Refactor input code

Looking forward to this

Thanks!

@ddevault ddevault merged commit 00b1b40 into swaywm:master Feb 23, 2019

3 checks passed

builds.sr.ht: alpine.yml builds.sr.ht job completed successfully
Details
builds.sr.ht: archlinux.yml builds.sr.ht job completed successfully
Details
builds.sr.ht: freebsd.yml builds.sr.ht job completed successfully
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.