Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootston: refactor rendering #1577

Merged
merged 5 commits into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@emersion
Copy link
Member

emersion commented Feb 25, 2019

  • Add surface iterators
  • Fix rotated views rendering
  • Fix input events offset with rotated views (maybe due to window geometry?)
  • Fix fullscreen Xwayland surface children not rendered
  • Split rendering code in render.c

Updates #839

@emersion emersion changed the title rootston: refactor rendering [WIP] rootston: refactor rendering Feb 25, 2019

@emersion emersion force-pushed the emersion:refactor-rendering branch 2 times, most recently from 591efc2 to dd299bc Feb 25, 2019

@emersion emersion changed the title [WIP] rootston: refactor rendering rootston: refactor rendering Mar 2, 2019

@emersion

This comment has been minimized.

Copy link
Member Author

emersion commented Mar 2, 2019

This PR is now ready for review.

Show resolved Hide resolved rootston/output.c Outdated
@ascent12
Copy link
Member

ascent12 left a comment

Overall looks good to me, but I can't say I'm particularly familiar with rootston.

emersion added some commits Feb 25, 2019

rootston: refactor rendering
This implements rootston surface iterators to ease rendering, sending
frame/presentation events and accumulating damage.

@emersion emersion force-pushed the emersion:refactor-rendering branch from 6751e00 to 493a22b Mar 2, 2019

@ddevault

This comment has been minimized.

Copy link
Member

ddevault commented Mar 2, 2019

LGTM, thanks!

@ddevault ddevault merged commit 6a60daf into swaywm:master Mar 2, 2019

3 checks passed

builds.sr.ht: alpine.yml builds.sr.ht job completed successfully
Details
builds.sr.ht: archlinux.yml builds.sr.ht job completed successfully
Details
builds.sr.ht: freebsd.yml builds.sr.ht job completed successfully
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.