Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

backend/drm: Simplify object matching code #1732

Merged
merged 1 commit into from Jun 22, 2019

Conversation

ascent12
Copy link
Member

@ascent12 ascent12 commented Jun 21, 2019

We originally used match_obj on planes, but this was largely unnecessary. Instead, this assigns planes statically at startup.

See #1723 (comment)
It'll help if some people could test this as well (especially hotplugging), so it's not just "works for me".

backend/drm/drm.c Outdated Show resolved Hide resolved
backend/drm/drm.c Outdated Show resolved Hide resolved
backend/drm/drm.c Outdated Show resolved Hide resolved
Copy link
Member

@ddevault ddevault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing

@ddevault
Copy link
Member

Holds up in testing 👍

We originally used match_obj on planes, but this was largely
unnecessary. Instead, this assigns planes statically at startup.
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't think we'll ever support planes with the legacy interface, so it probably doesn't matter to remove them.

@emersion emersion merged commit b3f4254 into swaywm:master Jun 22, 2019
@emersion
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants