This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
add xwayland unmanaged tests to support dmenu #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevault
approved these changes
Feb 25, 2018
emersion
reviewed
Feb 26, 2018
xwayland/xwayland.c
Outdated
| NET_WM_WINDOW_TYPE_POPUP_MENU, | ||
| NET_WM_WINDOW_TYPE_COMBO, }; | ||
|
|
||
| for (unsigned i = 0; i < sizeof(needles) / sizeof(needles[0]); ++i) { |
emersion
reviewed
Feb 26, 2018
xwayland/xwayland.c
Outdated
|
|
||
|
|
||
| bool wlr_xwayland_surface_is_unmanaged(const struct wlr_xwayland_surface *surface) { | ||
| static enum atom_name needles[] = { NET_WM_WINDOW_TYPE_UTILITY, |
There was a problem hiding this comment.
Style nitpick: add a newline after opening brackets and before closing brackets.
This adds `wlr_xwayland_surface_is_unamanged`, to allow compositors more fine grained control over XWayland focus. A surface that is unmanaged should not receive focus, while other windows that are just override redirect may want it (dmenu). The way unamanged is determined is taken from wlc.
Ongy
force-pushed
the
xwayland_unmanaged
branch
from
5981de0
to
bb67601
Compare
|
@Ongy It seems GitHub doesn't send notifications when you force-push. Feel free to ping again the reviewer when you do that. |
emersion
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
wlr_xwayland_surface_is_unamanged, to allow compositors morefine grained control over XWayland focus.
A surface that is unmanaged should not receive focus, while other
windows that are just override redirect may want it (dmenu).
The way unamanged is determined is taken from wlc.
This fixes #636
I have only tested this with a single seat. With the current way inital focus is applied, it may have interesting effect in multiseat setups when a popup/tooltip doesn't have the
NET_WM_TYPEset.