feat: add support for async transform #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SimenB
commented
Feb 24, 2022
SimenB
commented
Feb 24, 2022
| const supportsEsm = 'Module' in vm | ||
|
|
||
| function createTransformer(swcTransformOpts?: Options) { | ||
| function createTransformer(swcTransformOpts?: Options): Transformer { |
There was a problem hiding this comment.
mostly to type jestOptions correctly
|
Can you rebase? |
SimenB
force-pushed
the
add-async-transform
branch
from
ba0cd00
to
c841e23
Compare
|
Done 🙂 |
SimenB
force-pushed
the
add-async-transform
branch
from
eeaf892
to
044b0a0
Compare
SimenB
commented
Feb 25, 2022
SimenB
commented
Feb 25, 2022
| ...computedSwcOptions, | ||
| module: { | ||
| ...computedSwcOptions.module, | ||
| type: jestOptions.supportsStaticESM ? 'es6' : 'commonjs' |
There was a problem hiding this comment.
since we now also do async transformation, it's not safe to mutate the shared option as there might be concurrency issues
|
Thanks! Feel free to ping me if any issues crop up (I don't personally use this module, just noticed the needless complexity when browsing the code. I did verify it works for native ESM, though 🙂) |
SimenB
commented
Feb 25, 2022
| set(computedSwcOptions, 'module.type', isEsm(filename, jestOptions) ? 'es6' : 'commonjs') | ||
| } | ||
| process(src, filename, jestOptions) { | ||
| set(computedSwcOptions, 'module.type', jestOptions.supportsStaticESM ? 'es6' : 'commonjs') |
There was a problem hiding this comment.
oops, should have deleted this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest has supported async code transformation since v27, so why not support it.
And there's no need for this transformer to attempt to detect ESM support - Jest provides the necessary options (specifically
supportsStaticESM) as of v25.3.0.I can split this up into two PRs if you want