build: Update swc_core to v48.0.4

[kdy1]

This is to publish npm packages

[changeset-bot]

⚠️ No Changeset found

Latest commit: bcbbd94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[claude]

Pull Request Review: Update swc_core to v48.0.4

Overview

This PR updates the swc_core dependency from v48.0.0 to v48.0.4, along with related SWC dependencies. This is a maintenance release that includes bug fixes and improvements.

Code Quality ✅

Strengths:

• Consistent version updates across all packages and internal crates
• Proper use of workspace dependencies for version management
• Clean, mechanical changes with no custom logic modifications
• All Cargo.toml files correctly updated with matching versions

Observations:

• The PR updates 3 related dependencies:
  • swc_core: 48.0.0 → 48.0.4
  • swc_ecma_parser: 27.0.6 → 27.0.7
  • swc_ecma_minifier: 36.0.3 → 36.0.4
  • swc_ecma_transforms_base: 30.0.0 → 30.0.1

Potential Issues 🔍

Minor:

1. Changeset Removal: The .changeset/blue-rivers-leave.md file was deleted. This appears intentional for publishing, but verify this follows your changeset workflow correctly.

2. Version Bumps: All packages received minor version bumps (e.g., 13.1.0 → 14.0.0), which are marked as "Major Changes" in the changelogs. For a patch-level dependency update, consider whether major version bumps are necessary for all packages, or if patch/minor bumps would be more semantically appropriate.

3. Changelog Consistency: Two separate changelog entries are being added:

   • "ad79e09: Update swc_core to v48.0.4" (Patch)
   • "6c46f86: feat: Enable backward-compatibility feature" (Major)

   Ensure the "backward-compatibility feature" change is documented elsewhere or this is the intended messaging.

Performance Considerations ✅

• No performance concerns
• Dependency updates at this level typically include performance improvements and bug fixes
• The update is a patch version (48.0.0 → 48.0.4), suggesting bug fixes rather than breaking changes

Security Concerns ✅

• No security issues identified
• Dependency updates help maintain security posture
• No introduction of new dependencies or risky patterns

Test Coverage ✅

Strengths:

• CI checks are running (pending at review time)
• The repository has comprehensive test coverage with:
  • Integration tests (npm-test)
  • Cargo tests on multiple platforms (Ubuntu, Windows)
  • WASM tests for plugins
  • Cargo check with swc_ast_unknown flag

Recommendations:

• Wait for CI to complete successfully before merging
• Monitor for any test failures related to the dependency updates

Additional Observations

Positive:

• Cargo.lock properly updated with transitive dependency changes
• No manual code changes required, indicating good API stability
• All newline endings properly maintained at EOF

Minor Code Style:

• Several Cargo.toml files had missing newlines at EOF which were correctly added (e.g., contrib/mut-cjs-exports/Cargo.toml:30)

Recommendations

1. ✅ Merge when CI passes - This is a straightforward dependency update
2. ⚠️ Verify changeset workflow - Confirm the deleted changeset file is intentional
3. 💡 Consider semantic versioning - Evaluate if major version bumps are necessary for all packages given this is a patch-level dependency update
4. 📋 Monitor post-release - Watch for any issues in downstream consumers after publishing

Summary

This is a well-executed dependency update PR with consistent changes across all packages. The mechanical nature of the changes and comprehensive test suite provide confidence in the update. The main consideration is ensuring the version bump strategy (major vs. patch) aligns with your semantic versioning policy.

Recommendation: APPROVE ✅ (pending CI success)

---

Review generated with analysis of 67 changed files across Cargo manifests, package.json files, and changelogs.

[claude]

Pull Request Review - PR #557

Summary

This PR updates swc_core from v48.0.0 to v48.0.4, along with related dependencies (swc_ecma_parser, swc_ecma_transforms_base, swc_ecma_minifier). It also bumps versions for all 17 plugin packages and enables the backward-compatibility feature, resulting in major version releases (v12.0.0, v13.0.0, or v14.0.0) for all plugins.

Review Analysis

✅ Code Quality & Best Practices

Strengths:

• Clean, systematic dependency update following semantic versioning
• Consistent version bumping across all packages in the monorepo
• Proper changelog entries for all affected packages
• Follows the repository's release process with changesets

Observations:

• The PR includes two separate release cycles:
  1. Patch releases (v11.1.1, etc.) for the swc_core v48.0.4 update
  2. Major releases (v12.0.0, etc.) for enabling backward-compatibility feature
• All Cargo.toml files properly updated with new dependency versions
• Cargo.lock correctly regenerated with updated dependency checksums

🔍 Potential Issues

Minor Formatting Issues:

• Several Cargo.toml files had trailing newlines added (e.g., contrib/mut-cjs-exports/Cargo.toml:30, packages/emotion/transform/Cargo.toml:43)
• While this is a good practice for consistency, it's technically unrelated to the core dependency update
• These changes are harmless but could have been in a separate commit

No Code Changes:

• ✅ This is purely a dependency update and version bump - no functional code changes
• ✅ No breaking API changes introduced in the transform logic itself

🚀 Performance Considerations

Expected Impact:

• Dependency updates from SWC core typically include:
  • Performance improvements in parsing and transformations
  • Bug fixes in the underlying compiler
  • Potential optimizations in the WASM plugin system
• v48.0.0 → v48.0.4 is a patch-level change, suggesting bug fixes rather than major performance changes
• No performance regressions expected

Recommendation: Monitor the CI integration tests to ensure no performance degradation in actual plugin usage.

🔒 Security Concerns

Assessment: ✅ Low Risk

• Updating to a newer patch version of swc_core is generally a security-positive change
• No new dependencies introduced
• No changes to plugin logic that could introduce vulnerabilities
• The Socket Security checks are passing, indicating no new supply chain risks

Note: The backward-compatibility feature being enabled suggests the plugins will maintain compatibility with older SWC versions, which could be important for security patch adoption.

🧪 Test Coverage

Current Status:

• CI checks are pending/running at review time
• The following tests are configured:
  • Integration tests (Ubuntu, macOS)
  • Unit tests (Ubuntu, Windows)
  • Check with swc_ast_unknown feature ✅ (passing)
  • Socket Security checks ✅ (passing)

Observations:

• ✅ No test files were modified - appropriate for a dependency update
• ✅ The PR includes automated tests via CI
• ⚠️ The PR body states "This is to publish npm packages" but should wait for tests to pass before merging

Recommendations:

1. Wait for all integration tests to complete successfully
2. Verify that existing test suites adequately cover backward-compatibility scenarios
3. Consider manual smoke testing of at least 2-3 critical plugins (emotion, styled-components, relay) before publishing

📦 Release & Versioning

Version Strategy Analysis:

• Major version bump is appropriate because enabling backward-compatibility is a significant feature change
• All 17 packages receive synchronized version updates
• Changelog entries are well-formatted and informative
• The changeset mentions: "feat: Enable backward-compatibility feature"

Potential Concerns:

• Major version bumps suggest breaking changes, but the "backward-compatibility" feature name implies the opposite
• Users might be confused about why this is a major version if it adds compatibility
• Recommendation: Consider adding migration notes or clarifying in documentation what "backward-compatibility feature" means (likely it's a Cargo feature flag enabling compatibility with older SWC versions)

📝 Additional Recommendations

1. Documentation:

   • Consider adding a note in the main README about the backward-compatibility feature
   • Update plugin documentation if the new feature affects usage

2. Release Notes:

   • The changelog entries are good but could benefit from more details about what backward-compatibility entails
   • Consider adding a note about the swc_core version requirement

3. Versioning Clarity:

   • The two-step release process (patch → major) in a single PR is unusual
   • This suggests the PR was created after releases were already published
   • For future releases, consider separate PRs for patch updates vs feature additions

Final Verdict

✅ APPROVED with minor suggestions

This is a well-executed dependency update and feature release. The changes are:

• ✅ Technically sound
• ✅ Follow repository conventions
• ✅ Include proper changelog entries
• ✅ No security concerns identified
• ✅ No code quality issues

Prerequisites before merging:

1. ⏳ Wait for all CI tests to pass (currently pending)
2. ✅ Verify integration tests complete successfully
3. 📝 Consider clarifying the "backward-compatibility feature" in documentation

Risk Level: Low - This is a standard dependency update with proper version management.

Suggested Actions:

• Merge once CI passes ✅
• Monitor npm package publishing for any issues
• Consider a follow-up PR for documentation improvements