From 6d6731f355ed3bc314be31061b971f9317bea713 Mon Sep 17 00:00:00 2001 From: IWANABETHATGUY Date: Sun, 5 Mar 2023 15:28:01 +0800 Subject: [PATCH] fix(es/parser): Fix parsing of an array spread in tsx properties (#7011) --- crates/swc_ecma_parser/src/parser/jsx.rs | 3 +++ .../tests/jsx/fixture/issue-6977/1/input.js | 4 ++++ .../tests/jsx/fixture/issue-6977/1/output.mjs | 8 ++++++++ .../tests/jsx/fixture/issue-6977/2/input.js | 4 ++++ .../tests/jsx/fixture/issue-6977/2/output.mjs | 6 ++++++ 5 files changed, 25 insertions(+) create mode 100644 crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/1/input.js create mode 100644 crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/1/output.mjs create mode 100644 crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/2/input.js create mode 100644 crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/2/output.mjs diff --git a/crates/swc_ecma_parser/src/parser/jsx.rs b/crates/swc_ecma_parser/src/parser/jsx.rs index ebf37b196ba2..d897866c667a 100644 --- a/crates/swc_ecma_parser/src/parser/jsx.rs +++ b/crates/swc_ecma_parser/src/parser/jsx.rs @@ -143,6 +143,9 @@ impl Parser { let expr = if is!(self, '}') { self.parse_jsx_empty_expr().map(JSXExpr::JSXEmptyExpr)? } else { + if is!(self, "...") { + bump!(self); + } self.parse_expr().map(JSXExpr::Expr)? }; expect!(self, '}'); diff --git a/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/1/input.js b/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/1/input.js new file mode 100644 index 000000000000..00b47acafe07 --- /dev/null +++ b/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/1/input.js @@ -0,0 +1,4 @@ +function Component(props) { +} + + \ No newline at end of file diff --git a/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/1/output.mjs b/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/1/output.mjs new file mode 100644 index 000000000000..6b74ab0b78ba --- /dev/null +++ b/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/1/output.mjs @@ -0,0 +1,8 @@ +function Component(props) {} +/*#__PURE__*/ React.createElement(Component, { + x: [ + 1, + 2, + 3 + ] +}); diff --git a/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/2/input.js b/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/2/input.js new file mode 100644 index 000000000000..30539b437549 --- /dev/null +++ b/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/2/input.js @@ -0,0 +1,4 @@ +function Component(props) { +} + + \ No newline at end of file diff --git a/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/2/output.mjs b/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/2/output.mjs new file mode 100644 index 000000000000..e5a0d99a84c4 --- /dev/null +++ b/crates/swc_ecma_transforms_react/tests/jsx/fixture/issue-6977/2/output.mjs @@ -0,0 +1,6 @@ +function Component(props) {} +/*#__PURE__*/ React.createElement(Component, { + x: { + a: x + } +});