You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cspotcode
changed the title
TypeScript types for AmdConfigmoduleId should be optional
Several properties in TypeScript types for Config should be made optional
Jul 21, 2021
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.
Describe the bug
TypeScript types for
AmdConfig
markmoduleId
as required; should be optional.The type is declared are required here:
swc/node-swc/src/types.ts
Line 579 in ebdd04d
It is documented as optional here:
https://swc.rs/docs/swcrc-module#amd
EDIT I believe that a few more should also be made optional:
swc/node-swc/src/types.ts
Lines 407 to 456 in ebdd04d
ReactConfig
:importSource
,refresh
,runtime
Input code
N/A
Config
N/A
Expected behavior
Typechecking should pass when omitting
moduleId
frommodule
config object.Version
The version of @swc/core: master branch on github
The text was updated successfully, but these errors were encountered: