-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css/parser): normalize and improve function name #6667
feat(css/parser): normalize and improve function name #6667
Conversation
0245890
to
8f480fd
Compare
67920dd
to
b2cda90
Compare
Rebased |
@@ -100,12 +101,39 @@ impl Take for SimpleBlock { | |||
} | |||
} | |||
|
|||
#[ast_node] | |||
#[derive(Eq, Hash, Is, EqIgnoreSpan)] | |||
pub enum FunctionName { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdy1 Yeah, it reduce code, we have the same for AtRule
and Declaration
, so we will have less code
4087178
to
60c7bf4
Compare
@kdy1 Rebased 👍 |
60c7bf4
to
90fd03b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_css_ast --breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
Description:
Improve function name:
From spec (https://www.w3.org/TR/css-values-4/#dashed-idents):
js_word!()
BREAKING CHANGE:
Yes
Related issue (if exists):
No