New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact field for workshops is a list now (rather than a single value) #1191

Open
anenadic opened this Issue May 23, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@anenadic

anenadic commented May 23, 2017

Contact field for workshops is a list now (rather than a single value) in workshop template so this needs to be supported in AMY too. Values get concatenated without a space, a comma or other separator when updating workshop data from a URL. For example see workshop with slug: 2017-06-21-qmul.

@chrismedrela

This comment has been minimized.

Collaborator

chrismedrela commented Jul 10, 2017

The cause of the problem is in the workshop template, not AMY. When generating <meta> tags, the template still assumes that contact is a single value rather than a list: see the template. So the values get concatenated by jekyll, not AMY. Have a look at the source code of the mentioned workshop and you can see:

<meta name="contact" content="rebecca.stewart@qmul.ac.uka.nenadic@manchester.ac.uk" />

I believe we can still represent Event.contact as CharField if only we separate multiple emails with a comma or other separator. Let me know if you have different opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment