New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop request UI changes #1412

Open
wants to merge 15 commits into
base: develop
from

Conversation

Projects
None yet
1 participant
@pbanaszkiewicz
Member

pbanaszkiewicz commented Nov 15, 2018

This PR fixes a number of issues related to workshop-request submission form.

Workshop request: link to submit another
The link appears on the confirmation page.

This fixes #1404.

pbanaszkiewicz added some commits Nov 16, 2018

Use specific order for domains on workshop request form
The ordering is as follows:
1. order domains by name
2. but "Don't know yet" leave last in the list

It's achieved by Case(When()) in order_by clause.

This fixes #1405.
Rework LC curricula
This fixes #1419 by rewording 'lc' curriculum, and adding 'lc-other'.
Workshop request form: change wording on curricula help text
This fixes #1420 according to directives from that issue.
@pbanaszkiewicz

This comment has been minimized.

Member

pbanaszkiewicz commented Dec 5, 2018

@maneesha almost all issues (reported so far) regarding workshop requests form are resolved in this PR. I'm still waiting for your feedback on #1406 and #1407.

pbanaszkiewicz added some commits Dec 5, 2018

Add The Carpentries banner in SVG version
1. smaller
2. loads faster
3. looks better
Workshop request form: change fields order
Move `travel_expences_agreement` below `travel_expences_management`
field.
Fix JS imports related to DAL
I wonder if we ever fix them for good...

Anyway, there were two issues here:
1. wrong application imports in settings (DAL should come before django
   admin)
2. in some places we were using "raw" widgets from DAL, instead of
   modified widgets (that removed unnecessary JS imports).
Select2: add Bootstrap4 theme
It makes the select2 widgets look way better (more concise with the rest
of AMY).
Workshop request: remove `part_of_conference` field
This field was redundant, because non-empty value in
`conference_details` meant the workshop IS part of a conference or
larger event.
Workshop request form: display `insitution_name` as a subfield
This fixes #1406.

Additional change: other subfields, used in
`CheckboxSelectMultipleWithOther` and `RadioSelectWithOther`, were
changed to small fields (`form-control-sm` in Bootstrap4).
@pbanaszkiewicz

This comment has been minimized.

Member

pbanaszkiewicz commented Dec 9, 2018

@maneesha: please confirm this layout:

screenshot_2018-12-09 amy request a carpentries workshop 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment