New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening of the Version Control lesson starts with an assumption #508

Open
iglpdc opened this Issue May 6, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@iglpdc
Contributor

iglpdc commented May 6, 2018

(From swcarpentry/shell-novice#774)

The first line of the Version Control with GIT Tracking Changes starts at a point that stopped me.
It says:
"First let’s make sure we’re still in the right directory. You should be in the planets directory.
$ pwd"

I did not know where to find the "planets" directory. I would like to "lead in" statement that says: "Go to the directory where you will find the planets directory"
and add a link.

(cc @sandycampbell)

@iglpdc

This comment has been minimized.

Contributor

iglpdc commented May 6, 2018

Thanks, @sandycampbell !

I agree that this first sentence can be confussing. What do you think about keeping the text as it is, but changing the command?

First let’s make sure we’re still in the right directory. You should be in the planets directory.

$ cd 
$ cd /Desktop/planets

This will work in all the operating systems and in the previous episode the planets directory is created in the Desktop, so everybody should have it there.

Would you like to submit a PR with this change?

@rsuchecki

This comment has been minimized.

rsuchecki commented Oct 4, 2018

There are a few issues with this issue:

  1. The first line in 4. Tracking Changes follows directly from the work in 3. Creating a Repository so unless someone skips the previous section it is all pretty clear.
  2. The proposed solution appears to be incorrect, as it expects the Desktop directly under the root / directory (/Desktop/planets) which is inconsistent with the rest of the lesson. The intended directory location is ~/Desktop/planets, that is, /home/${USER}/Desktop/planets

Conclusion: this issue should either be

  • closed with a wont-fix label
    or
  • the first line could be kept and the following 6 lines replaced with
cd ~/Desktop/planets

Lines to be removed in this case:

$ pwd
/home/vlad/Desktop/planets

If you are still in moons, navigate back up to planets

$ pwd
/home/vlad/Desktop/planets/moons
$ cd ..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment