Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson 3: Add description for force delete in Solutions #558

Closed
krishnanj opened this issue Sep 24, 2018 · 2 comments
Closed

Lesson 3: Add description for force delete in Solutions #558

krishnanj opened this issue Sep 24, 2018 · 2 comments

Comments

@krishnanj
Copy link
Contributor

In [lesson-3/ Creating a Repository] of Version Control with Git there is a solution at the end which describes how to remove the .git folder in the moons subdirectory.

Here the idea of recursive force deletion of folders is motivated using the command rm -rf moons/.git. However, from my skimming, there is no description of what is force delete or why we should use it here, only a warning to use it carefully. I think it is useful to have a longer description in the solutions section. If this issue is approved, I can submit a PR for the same.

On a similar note, I also noticed that there isn't a focus on removing files and directories with git [correct me if I am wrong]. Perhaps its good to integrate a short description on git rm commands in one of the tutorials?

@nhejazi
Copy link
Contributor

nhejazi commented Dec 29, 2018

Thanks for bringing this up; I think this is a good point. In my teaching experience, usually the Git lesson is taught after a lesson that introduces shell commands, so this lack of explanation of rm -rf is possibly an artifact of relying on teaching in that order. I do think it's worth adding a short description of rm -rf as done in #560 so that the inherent danger in possibly abusing this command is less nebulous.

On another note, this is a fairly introductory lesson and I think git rm and related commands might be out of scope for this level of introduction. It would be nice to see a lesson covering some of these concepts but it might fall in an appendix section of the lesson or under advanced topics.

@nhejazi
Copy link
Contributor

nhejazi commented Dec 29, 2018

Resolved by #560.

@nhejazi nhejazi closed this as completed Dec 29, 2018
fmichonneau pushed a commit to fmichonneau/git-novice that referenced this issue Jul 1, 2021
Add catch for None type code block in lesson_check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants