Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson 08: A better description of the reviewing process through GitHub #582

Open
Roland-djee opened this issue Dec 18, 2018 · 1 comment
Open

Comments

@Roland-djee
Copy link

@Roland-djee Roland-djee commented Dec 18, 2018

Please delete the text below before submitting your contribution.


In lesson 08, when it comes to review the changes made by a Owner broached in the exercises, can be a bit more explanatory in my opinion. I could be mentioned that the Owner can add the Collaborator as a Reviewer and that he/she gets notified through the email address set at the beginning. This has the advantage to engage with the reviewing process on GitHub and what would make a good review, and how to resolve a conversation for a satisfactory merge of the PR.


@munkm
Copy link
Member

@munkm munkm commented Jan 22, 2019

Hi @UCLGuichard. Thanks for the issue! Where exactly in lesson 08 do you think these changes should happen? Just after the a basic collaborative workflow callout box? One of the exercises in lesson 08 (Comment Changes in GitHub) talks a bit about interacting with Github and commenting on specific changes. What do you think about updating this exercise to be a bit clearer (some of the wording is unclear) and to also have one of the pair-programmers add their partner as a reviewer to solicit feedback on github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants