Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June 2019 Lesson Release checklist #611

Open
fmichonneau opened this issue Apr 16, 2019 · 8 comments

Comments

@fmichonneau
Copy link
Member

commented Apr 16, 2019

If your Maintainer team has decided not to participate in the June 2019 lesson release, please close this issue.

To have this lesson included in the 18 June 2019 release, please confirm that the following items are true:

  • Example code chunks run as expected
  • Challenges / exercises run as expected
  • Challenge / exercise solutions are correct
  • Call out boxes (exercises, discussions, tips, etc) render correctly
  • A schedule appears on the lesson homepage (e.g. not “00:00”)
  • Each episode includes learning objectives
  • Each episode includes questions
  • Each episode includes key points
  • Setup instructions are up-to-date, correct, clear, and complete
  • File structure is clean (e.g. delete deprecated files, insure filenames are consistent)
  • Some Instructor notes are provided
  • Lesson links work as expected

When all checkboxes above are completed, this lesson will be added to the 18 June lesson release. Please leave a comment on carpentries/lesson-infrastructure#26 or contact Erin Becker with questions (ebecker@carpentries.org).

@kekoziar

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@iglpdc @daisieh @munkm @nhejazi I think we can work through the checklist for the lesson as it currently stands. The question is can we address/incorporate #277 before the deadline?

@munkm

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

I think we should wait to do #277 until we hear back from the CAC.

@munkm

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

For Lesson links work as expected issues #618, #619, #620, and #622 were created.

@kekoziar

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

For lesson Example code chunks run as expected, some of the output has changed due to either changes in the lesson, git base code, or github responses. Issues #621, #623, #624, #625, #626, and #627 were created in response, detailing the issue and specifying the updated needed, sometimes with verbatim code.

@kekoziar kekoziar pinned this issue May 6, 2019

@munkm

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

For Each episode contains key points issues #629 and #630 were created. However, all episodes currently do have key points so this isn't a blocker for the lesson release.

@munkm

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

For Each episode includes learning objectives issue #631 was opened. However, all episodes currently have learning objectives so this issue isn't a blocker for the lesson release.

@kekoziar

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

For Challenges / exercises run as expected and Challenge / exercise solutions are correct, issues #632, #633, #634, #635, #636 were opened. All other exercises and solutions run and are correct.

@kekoziar

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

I checked Call out boxes (exercises, discussions, tips, etc) render correctly. Currently, they all render correctly; however, parts of the lesson that change from issues opened as a result of process should be rechecked. So, this checkbox will remain unchecked until after issues have been processed and completed, allowing a last check for proper rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.