Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 5 - History: References to HEAD~2 need to be updated #621

Closed
kekoziar opened this issue May 6, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@kekoziar
Copy link
Contributor

commented May 6, 2019

References to HEAD~2 need to be updated to HEAD~3.
Since we added/committed the spaceships directories at the end of Episode 4, at this point HEAD~3 would refer to the first commit.

@munkm munkm added this to the June 2019 Release milestone May 6, 2019

@kekoziar kekoziar referenced this issue May 6, 2019

Open

June 2019 Lesson Release checklist #611

8 of 12 tasks complete
@munkm

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

Quick question -- since the spaceships directories stuff in Episode 4 was in a callout do we assume that all instructors will do it? The lesson style guide (https://carpentries.github.io/lesson-example/04-formatting/index.html) says that the callout is an "aside", so this update is dependent on whether we assume that all instructors will follow it.

I'm about to submit a PR to update these references, but it can be closed if we decide that a callout isn't in the main lesson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.