Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 5 - History: Incorrect header for log output #623

Open
kekoziar opened this issue May 6, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@kekoziar
Copy link
Contributor

commented May 6, 2019

The episode has as output for
git show HEAD~2 mars.txt

commit 34961b159c27df3b475cfe4415d94a6d1fcd064d
Author: Vlad Dracula <vlad@tran.sylvan.ia>
Date:   Thu Aug 22 10:07:21 2013 -0400

    Start notes on Mars as a base

diff --git a/mars.txt b/mars.txt
new file mode 100644
index 0000000..df0654a
--- /dev/null
+++ b/mars.txt
@@ -0,0 +1 @@
+Cold and dry, but everything is my favorite color

But

commit 34961b159c27df3b475cfe4415d94a6d1fcd064d
Author: Vlad Dracula <vlad@tran.sylvan.ia>
Date:   Thu Aug 22 10:07:21 2013 -0400

refers to "Add concerns about effects of Mars' moons on Wolfman"

The proper header for the first commit should be

commit f22b25e3233b4645dabd0d81e651fe074bd8e73b
Author: Vlad Dracula <vlad@tran.sylvan.ia>
Date:   Thu Aug 22 09:51:46 2013 -0400

This should be fixed because in the episode, we refer extensively to the logs. The next lines refer to the correct commit id of f22b25...

Also, take care that this fix is not in conflict with issue 621, which fixes the HEAD reference number to the first commit.

@munkm munkm added this to the June 2019 Release milestone May 6, 2019

@kekoziar kekoziar referenced this issue May 6, 2019

Open

June 2019 Lesson Release checklist #611

7 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.