Addresses Issue 283 to double check the wd #285

Open
wants to merge 2 commits into
from

Projects

None yet

4 participants

@gallington

Added a few lines to check the working directory is reset to the correct level after the last section.

@iglpdc
Contributor
iglpdc commented Jun 13, 2016

Two things. One is that you added your commit on from an outdated repo. You can remove the old commit and rebase, but maybe it's easier to to the PR again in a fresh repo:

$ git checkout master
$ git pull upstream master
$ git checkout new-issue-283
(add your changes and submit the PR anew)

The second issue is that it'd be better not to assume that everyone has created the moons dir or that they created it under planets: some instructors may not to choose this exercise or use a different dir and some learners may accidentally create the repo in a different place. The safest is to ask everyone to go back to planets (see my comment in #283)

@iglpdc iglpdc added the enhancement label Jun 13, 2016
@iglpdc iglpdc self-assigned this Jun 13, 2016
@iglpdc iglpdc added this to the Version 5.4 milestone Jun 13, 2016
@gallington

Great! Good call I thought of that later. Will go back and change it

Sent from my iPhone

On Jun 13, 2016, at 4:13 PM, Ivan Gonzalez notifications@github.com wrote:

Two things. One is that you added your commit on from an outdated repo. You can remove the old commit and rebase, but maybe it's easier to to the PR again in a fresh repo:

$ git checkout master
$ git pull upstream master
$ git checkout new-issue-283
(add your changes and submit the PR anew)
The second issue is that it'd be better not to assume that everyone has created the moons dir or that they created it under planets: some instructors may not to choose this exercise or use a different dir and some learners may accidentally create the repo in a different place. The safest is to ask everyone to go back to planets (see my comment in #283)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@iglpdc
Contributor
iglpdc commented Jun 23, 2016

Hey @gallington, do you have some time to work on this in the next couple of days? Otherwise I can add a commit on top of yours to finish it myself.

@gallington

Sure! I was traveling but am back in office now. Pardon the delay.

Sent from my iPhone

On Jun 23, 2016, at 12:56 AM, Ivan Gonzalez notifications@github.com wrote:

Hey @gallington, do you have some time to work on this in the next couple of days? Otherwise I can add a commit on top of yours to finish it myself.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@gvwilson
Member

Can this one be merged now?

@rgaiacs
Contributor
rgaiacs commented Aug 27, 2016

Hey @gallington, do you have some time to work on this in the next couple of days?

@rgaiacs rgaiacs added a commit to rgaiacs/swc-git-novice that referenced this pull request Aug 27, 2016
@rgaiacs rgaiacs Add clarification of working directory to start of Tracking Changes s…
…ection

Close #283 and #285.
01b2292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment