Tracking Changes formatting and output fix #356

Open
wants to merge 2 commits into
from

Projects

None yet

2 participants

@brainwane

This pull request fixes Markdown formatting for the solution display in the "committing multiple files" exercise, and makes the output more realistic by including the "create mode" output the user would see when adding a new file to the repo.

Fixes #355.

@brainwane brainwane Improve Episode 4 exercise output.
The "committing multiple files" exercise includes the
creation and tracking of a new file, so this commit
adds the "create mode" output that the user would
see for that commit.
115707b
@@ -637,11 +637,12 @@ repository (`git commit`):
> > {: .bash}
> > ~~~
> > [master cc127c2]
-> > Wrote down my plans to start a base on venus
-> > 2 files changed, 2 insertions(+)
+> > Wrote down my plans to start a base on venus
@rgaiacs
rgaiacs Oct 31, 2016 Contributor

Why the extra space?

@brainwane
brainwane Oct 31, 2016

The extra space is to replicate what the output looks like in the terminal -- at least on my machine, when I make a commit, the first line of the output (i.e., the line starting [master cc127c2]) is all the way over to the left, and everything after that is indented by a single space.

Example:

$ git commit -m "Initial commit"
[master (root-commit) fe775a8] Initial commit
 1 file changed, 11 insertions(+)
 create mode 100644 build-classification.py
_episodes/04-changes.md
> > ~~~
> > {: .output}
-> > ~~~
+> >
@rgaiacs
rgaiacs Oct 31, 2016 Contributor

We can remove this line.

@brainwane
brainwane Oct 31, 2016

Thanks! I've removed it in the amended commit.

@brainwane brainwane Fix formatting in Tracking Changes exercise
Markdown fix to make solution display properly.

Fixes #355.
c059835
@brainwane

Thanks for the review @rgaiacs -- I've revised the PR and it's ready for fresh review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment