Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resources, considerations, and examples to licensing.md #604

Closed
wants to merge 2 commits into from

Conversation

@acolum
Copy link

@acolum acolum commented Mar 27, 2019

Added:

  • the Open Source Guide as a further resource to learn about licenses and choose one
  • examples of open source licenses to consider for different communities and end-goals
Added:
- the Open Source Guide as a further resource to learn about licenses and choose one
- examples of open source licenses to consider for different communities and end-goals
@@ -37,6 +38,25 @@ considerations include:
* Whether the content you are licensing is source code.
* Whether you want to license the code at all.

You may also want to consider the communities you hope will use and
Copy link
Member

@munkm munkm May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the material you've added here and I really like how you've framed licenses within the communities lens. However, it's adding quite a bit of content to the lesson, which is adding to our already-too-long lesson see our contributing guidelines. However, we're always looking for new exercises and exercise solutions! I think this is exactly the type of content that could be put into an exercise. Would you mind reframing what you've written here as an exercise (you already have the solutions!) at the end of the section instead?

Loading

Copy link
Author

@acolum acolum May 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I just went ahead and changed the format of this chunk of text to an exercise. Please let me know if you'd like me to make any additional changes.

Loading

Copy link
Contributor

@kekoziar kekoziar Jul 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like the changes, and agree it is better as an exercise. While you put it in the exercise formatting, it's not written as an exercise. Can you reframe it as an exercise?

One way of reframing it would be Use choosealicense.com to determine the best license for the following types of projects...

List the projects as an ordered list.

List the answers in an answer section, as an ordered lists.

Exercises should allow learners to go through a process to discover the answers themselves.

Loading

@@ -14,7 +14,7 @@ keypoints:
- "People who are not lawyers should not try to write licenses from scratch."
---

When a repository with source code, a manuscript or other creative
When a repository with source code, a manuscript, or other creative
Copy link
Member

@munkm munkm May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

Loading

Change previous contribution about licenses in context of community to an exercise.
@kekoziar
Copy link
Contributor

@kekoziar kekoziar commented Jul 30, 2021

I'm going to close this because changes requested by maintainers were never implemented, and PR appears abandoned. Please feel free to reopen or submit a new PR with requested changes (latter preferable as it resolves conflicts, and allow author to take into account any changes to the lesson text since this PR).

Loading

@kekoziar kekoziar closed this Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants