Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aoi.md from boilerplate. #653

Open
wants to merge 1 commit into
base: gh-pages
from

Conversation

Projects
None yet
2 participants
@iamc
Copy link

commented May 28, 2019

Fixes #652

@munkm munkm referenced this pull request May 28, 2019

Closed

Upgrade style 9.5.3 #654

@fmichonneau

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Thank you for contribution @iamc!

It looks like you correctly updated the yaml header to match the newer version of the file that is in the styles repository, however the content of the body of the file has also changed. Could you please update your pull request to also include the updated code in the file? thanks!

@iamc

This comment has been minimized.

Copy link
Author

commented May 29, 2019

I updated from the file bin/boilerplate/aio.m in this same repo and all-in-one generation seems to work ok.

I did try replacing, as by @fmichonneau suggestion, with the one in https://github.com/carpentries/styles/blob/gh-pages/bin/boilerplate/aio.md but this does not generate the all-in-one page, but tries to download the aio.md file instead. At least when serving the page locally in my computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.