Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade style 90f06fc #662
added some commits
Jun 1, 2018
Merge pull request #303 from katrinleinweber/patch-3
links.md: add links to carpentries' lessons overview pages
lesson_check.py: check YAML headers in Rmd episodes
Check that Rmd episode files include `source: Rmd` Fixes carpentries/styles#273
Merge pull request #317 from carpentries/fix-311
[fix carpentries/styles#311] update descriptions of the carpentries
Merge pull request #318 from carpentries/tracykteal-patch-1
added about the discussion stage to the LC description
Fix lesson_initialize.py to initialize new lessons
CODE_OF_CONDUCT.md is already at the root of the repository.
added some commits
Mar 6, 2019
Prefix code blocks with language names
Also, improve contrast of comments Signed-off-by: Maxim Belkin <firstname.lastname@example.org>
reference to the webpage of the lesson + goodfirst
This contribution adds reference to the web page of the lesson in the Carpentries and makes it easier for visitors who want to contribute to get familiar with the good first issue badge. This adds a list of current maintainers to the README.md.
aio.md: multiple improvements
Pull Request: carpentries/styles#406 * change all-in-one file to have the same 'depth' as episode files * move the core script of aio.md into _includes/aio-script.md * include comment to inform maintainers to not edit the file * move aio.md to the root of styles repository
Hi, @fmichonneau. I have a question about this style upgrade. When I render this PR of the git-novice lesson locally, the font size in callout boxes, exercises/challenges, and overview is markedly larger than the lesson text. I have replicated this on two different machines. Below is a screenshot of the git-novice lesson compared to the r-novice-inflammation lesson (which is upgraded to style 9.5.3). I also cloned r-novice-inflammation and rendered it locally, and it does not show a font size difference. Is this font size difference in the PR correct?
Also, I noticed the code boxes do not always have a complete outline. I tested this with local git-novice and the live r-novice-inflammation, and both exhibit the behavior. It seems to be a browser issue, where the code boxes render with a complete outline on FireFox, but not on Chrome nor Edge. I am less worried about this, but thought you should know of the issue.
Can you help with the font size issue? If you do not see this issue locally, will you share the version of ruby, jekyll, and bundler you are running?