Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade style 90f06fc #662

Open
wants to merge 115 commits into
base: gh-pages
from

Conversation

Projects
None yet
@fmichonneau
Copy link
Member

commented Jun 4, 2019

here is a PR to upgrade to the latest version of the lesson template.

brownsarahm and others added some commits Jun 1, 2018

Merge pull request #1 from swcarpentry/gh-pages
_config.yml: no 'mailto' in 'email'
Merge pull request #303 from katrinleinweber/patch-3
links.md: add links to carpentries' lessons overview pages
lesson_check.py: check YAML headers in Rmd episodes
Check that Rmd episode files include `source: Rmd`

Fixes carpentries/styles#273
Belinda Weaver
Merge pull request #317 from carpentries/fix-311
[fix carpentries/styles#311] update descriptions of the carpentries
Merge pull request #318 from carpentries/tracykteal-patch-1
added about the discussion stage to the LC description
Merge pull request #328 from carpentries/fix-survey
fix survey link variables
Merge pull request #333 from maxim-belkin/fix-makefile
Makefile: fix typo in clean-rmd rule
Fix lesson_initialize.py to initialize new lessons
CODE_OF_CONDUCT.md is already at the root of the repository.
Merge pull request #338 from rgaiacs/336
Fix lesson_initialize.py to initialize new lessons
Merge pull request #326 from carpentries/callout-margins
space out callout elements better

maxim-belkin and others added some commits Mar 6, 2019

Prefix code blocks with language names
Also, improve contrast of comments

Signed-off-by: Maxim Belkin <maxim.belkin@gmail.com>
reference to the webpage of the lesson + goodfirst
This contribution adds reference to the web page of the lesson in the Carpentries and makes it easier for visitors who want to contribute to get familiar with the good first issue badge.
This adds a list of current maintainers to the README.md.
gold colour to badge
gold looks more like the yellow from the original badge
use ndash as separator
display it only if both `page.title` and `site.title` are defined.
aio.md: multiple improvements
Pull Request: carpentries/styles#406

* change all-in-one file to have the same 'depth' as episode files

* move the core script of aio.md into _includes/aio-script.md

* include comment to inform maintainers to not edit the file

* move aio.md to the root of styles repository

@fmichonneau fmichonneau referenced this pull request Jun 4, 2019

Closed

Upgrade style 9.5.3 #654

@kekoziar

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Hi, @fmichonneau. I have a question about this style upgrade. When I render this PR of the git-novice lesson locally, the font size in callout boxes, exercises/challenges, and overview is markedly larger than the lesson text. I have replicated this on two different machines. Below is a screenshot of the git-novice lesson compared to the r-novice-inflammation lesson (which is upgraded to style 9.5.3). I also cloned r-novice-inflammation and rendered it locally, and it does not show a font size difference. Is this font size difference in the PR correct?
compareStyles_git-novice_v_r-inflammation-annotated

Also, I noticed the code boxes do not always have a complete outline. I tested this with local git-novice and the live r-novice-inflammation, and both exhibit the behavior. It seems to be a browser issue, where the code boxes render with a complete outline on FireFox, but not on Chrome nor Edge. I am less worried about this, but thought you should know of the issue.

Can you help with the font size issue? If you do not see this issue locally, will you share the version of ruby, jekyll, and bundler you are running?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.